Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: check raftcluster nil (#7054) #7068

Merged
merged 6 commits into from
Sep 14, 2024
Merged

*: check raftcluster nil (#7054) #7068

merged 6 commits into from
Sep 14, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7054

What problem does this PR solve?

Issue Number: Close #7053

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 11, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Sep 11, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2023
@HuSharp
fix
79b55e0 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-7054-to-release-5.4 branch from 2a303e5 to 79b55e0 Compare September 13, 2023 05:32
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 13, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 20, 2023
@HuSharp
Copy link
Member

HuSharp commented Sep 20, 2023

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 20, 2023

@HuSharp: No presubmit jobs available for tikv/[email protected]

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
rerun
ae68a09 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-7054-to-release-5.4 branch from ebc3015 to ae68a09 Compare February 23, 2024 10:01
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.75000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 74.60%. Comparing base (21b47d2) to head (ae68a09).

Files Patch % Lines
server/server.go 41.66% 9 Missing and 5 partials ⚠️
server/handler.go 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-5.4    #7068      +/-   ##
===============================================
- Coverage        74.80%   74.60%   -0.21%     
===============================================
  Files              265      265              
  Lines            28019    28032      +13     
===============================================
- Hits             20961    20913      -48     
- Misses            5216     5254      +38     
- Partials          1842     1865      +23
Flag Coverage Δ
unittests 74.60% <43.75%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuSharp
Copy link
Member

HuSharp commented Feb 26, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ae68a09

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 26, 2024
@HuSharp
resolve conflict
9717182 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. approved labels Sep 13, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato, lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuSharp,JmPotato,lhy1024,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-14 02:43:34.646807839 +0000 UTC m=+669884.387231782: ☑️ agreed by rleungx.
  • 2024-09-14 02:57:49.60476818 +0000 UTC m=+670739.345192118: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 9365b94 into tikv:release-5.4 Sep 14, 2024
12 checks passed
@HuSharp HuSharp deleted the cherry-pick-7054-to-release-5.4 branch September 14, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees

@HuSharp HuSharp

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @HuSharp @JmPotato @lhy1024 @rleungx